Fix HDFS remote_base to use path for compatibility with hdfs client #50804
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nevcohen
reviewed
May 21, 2025
airflow-core/src/airflow/config_templates/airflow_local_settings.py
Outdated
Show resolved
Hide resolved
providers/apache/hdfs/src/airflow/providers/apache/hdfs/log/hdfs_task_handler.py
Show resolved
Hide resolved
potiuk
approved these changes
May 29, 2025
potiuk
requested changes
May 29, 2025
Member
potiuk
left a comment
potiuk
left a comment
There was a problem hiding this comment.
Strange - your change touches OSS which is alibaba?
Contributor
Author
You're right - I edited the wrong block. Thanks for pointing it out. |
romsharon98
approved these changes
Jun 22, 2025
potiuk
approved these changes
Jun 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the remote_base configuration for HDFS logging to ensure only the HDFS path is used, instead of the full URL. This is necessary for compatibility with the hdfs.InsecureClient.write() method, which expects paths relative to the HDFS client root.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.